Update Tree Traversal C#. #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method and make the constructor do it instead.
june128
added
the
Implementation Edit
zsparal
suggested changes
Jul 3, 2018
| Node temp; | ||
| var stack = new Stack<Tree>(); | ||
| stack.Push(this); | ||
| Tree temp; | ||
|
|
||
| while (stack.Count != 0) | ||
| { | ||
| Console.WriteLine(stack.Peek().Id); | ||
| temp = stack.Pop(); |
There was a problem hiding this comment.
I would just do Tree temp = stack.Pop() instead of the separate declaration/initialization
zsparal
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure code by removing the
Nodeclass. RemoveCreateAllChildrenmethod and make the constructor do it instead.This is applying the changes suggested @Gustorn in #137 in discussion with @xam4lor .
The PR also removes the
CreateAllChildrenmethod and just makes the constructor recursive and do the creation.